search

lightstep / lightstep-tracer-android

The Lightstep distributed tracing library for Android.
https://lightstep.com
MIT License
8 stars 1 forks source link

Lightstep Tracer for Android conflicts with Firebase Performance Monitoring. #44

Open NikitaKozlov opened 4 years ago

NikitaKozlov commented 4 years ago

Hi, all! I have a problem with Lightstep integration for Android (https://github.com/lightstep/lightstep-tracer-android). Lightstep SDK for Android depends on com.google.protobuf:protobuf-java, it conflicts with com.google.protobuf:protobuf-javalite that a dependency we want to add uses (Firebase Performance Monitoring). According to https://github.com/protocolbuffers/protobuf/blob/master/java/lite.md, Android libraries should use the "javalite" version. Could you help me resolve this conflict?

Currently I'm trying to make a shadow version of lighstep-tracer-android similar to https://github.com/lightstep/lightstep-tracer-java/blob/master/shadow/pom.xml#L71-L72. What do you think about it?

caraesten commented 3 years ago

I'm also running into this issue. The Lightstep-Android project depends on the full protobuf via the com.lightstep.tracer:java-common library. This is an issue because Android projects, like the above poster mentioned, need to depend on the lite protobuf library, or else dependency conflicts will arise.

Is this something that Lightstep can commit to fixing?

caraesten commented 3 years ago

Note that this is still not fixed in the latest release; for anyone who uses Firebase, this library will break their build.