search

lightstep / lightstep-tracer-android

The Lightstep distributed tracing library for Android.
https://lightstep.com
MIT License
8 stars 1 forks source link

OptionsBuilder may make a network call on the main thread #53

Open Plastix opened 3 years ago

Plastix commented 3 years ago

Our team recently updated to 0.25.0 of the Lightstep Android SDK and are now seeing Android StrictMode violations from NetworkOnMainThreadException. It looks like this has to do with default hostname lookup:

Caused by: android.os.NetworkOnMainThreadException
        at android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1605)
        at java.net.Inet6AddressImpl.lookupHostByName(Inet6AddressImpl.java:115)
        at java.net.Inet6AddressImpl.lookupAllHostAddr(Inet6AddressImpl.java:103)
        at java.net.InetAddress.getLocalHost(InetAddress.java:1488)
        at com.lightstep.tracer.shared.Options$OptionsBuilder.getHostName(Options:661)
        at com.lightstep.tracer.shared.Options$OptionsBuilder.defaultHostname(Options:655)
        at com.lightstep.tracer.shared.Options$OptionsBuilder.build(Options:586)

See: https://github.com/lightstep/lightstep-tracer-java-common/blob/77e45ff5223d4323d74064f0a2c25f7f8147e486/common/src/main/java/com/lightstep/tracer/shared/Options.java#L645-L657=