search

lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go
https://lightstep.com
MIT License
98 stars 54 forks source link

Binary propagator does not accept the io.Reader/io.Writer #147

Closed vetinari closed 6 years ago

vetinari commented 6 years ago

The github.com/opentracing/opentracing-go says:

const (
    // Binary represents SpanContexts as opaque binary data.
    //
    // For Tracer.Inject(): the carrier must be an `io.Writer`.
    //
    // For Tracer.Extract(): the carrier must be an `io.Reader`.
    Binary BuiltinFormat = iota

calling sc, err := ot.GlobalTracer().Extract(ot.Binary, bytes.NewBuffer(traceData)) always results in ot.ErrInvalidCarrier