support io.Writer/io.Reader for Inject/Extract

lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go

https://lightstep.com

MIT License

98 stars 54 forks source link

support io.Writer/io.Reader for Inject/Extract #148

Closed vetinari closed 6 years ago

vetinari commented 6 years ago

This supports io.Writer for tracer.Inject() and io.Reader for tracer.Extract() as required by github.com/opentracing/opentracing-go.

Also: fixes to accept opentracing.Binary as parameter for Inject/Extract instead of lightstep.BinaryCarrier

fixes #147

joeblubaugh commented 6 years ago

CircleCI is being painful with this change - it's not running tests after I updated a setting that should cause them to be run. I opened #150, which should get around this. Thanks for the fix!

joeblubaugh commented 6 years ago

And, when I created the new PR it also kicked off this build. Hm.