search

lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go
https://lightstep.com
MIT License
98 stars 54 forks source link

support io.Writer/io.Reader for Inject/Extract #150

Closed joeblubaugh closed 6 years ago

joeblubaugh commented 6 years ago

This supports io.Writer for tracer.Inject() and io.Reader fortracer.Extract() as required by github.com/opentracing/opentracing-go.Also: fixes to accept opentracing.Binary as parameter for Inject/Extractinstead of lightstep.BinaryCarrierfixes #147

This PR clones #148 (from @vetinari) to fix a CircleCI state machine issue.

joeblubaugh commented 6 years ago

Closing because kicking this one off also kicked off the original PR #148 148