lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go
https://lightstep.com
MIT License
98 stars 54 forks source link

Generate protobuf files with gogo/protobuf #173

Open achille-roussel opened 5 years ago

achille-roussel commented 5 years ago

Hello,

I noticed that the generated protobuf files use the default code generator from Google, which is known for generating code with significant runtime overhead (due to heavy use of reflection and pointer types).

gogo/protobuf is an alternative implementation of the code generator and libraries, with a focus on lowering the runtime footprint of the protobuf generated files.

I was wondering if there was a reason why the lightstep tracer was not using gogo/protobuf?

iredelmeier commented 5 years ago

We'll be exploring gogo moving forward :)

I'll keep this issue updated with future experiments, etc.

achille-roussel commented 5 years ago

Thanks for the update!