The http client implementation was using http.Transport for plain http, and http2.Transport for https, which is already the default behavior of the standard library (since http2 support was introduced in Go 1.6).
It seems like the extra dependency on x/net/http2 is unnecessary and the lightstep client could use the default http transport without losing any features.
The PR also fixes support for http proxies, and adds a couple of sane defaults for various configuration options of the http transport.
This PR is a follow up from our conversation in https://github.com/lightstep/lightstep-tracer-go/issues/149
The http client implementation was using
http.Transportfor plain http, andhttp2.Transportfor https, which is already the default behavior of the standard library (since http2 support was introduced in Go 1.6).It seems like the extra dependency on
x/net/http2is unnecessary and the lightstep client could use the default http transport without losing any features.The PR also fixes support for http proxies, and adds a couple of sane defaults for various configuration options of the http transport.