newSpan not confirming type assertion (panic)

lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go

https://lightstep.com

MIT License

98 stars 54 forks source link

newSpan not confirming type assertion (panic) #182

Closed iheanyi closed 5 years ago

iheanyi commented 5 years ago

Is this intentional? This line specifically here should probably be refCtx, ok and if it's !ok, it should bail out. Unless there's a good reason for it panicking that I'm unaware of. I was burned by this today unexpectedly, so any insights would be great. Thank you!

iredelmeier commented 5 years ago

No reason that I am aware of. #183 should fix it.

iheanyi commented 5 years ago

Thank you for fixing this @iredelmeier! :D