search

lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go
https://lightstep.com
MIT License
98 stars 54 forks source link

Add meta event reporting LS-6841 #187

Closed austinlparker closed 5 years ago

austinlparker commented 5 years ago

This PR adds support for reporting 'meta events' - detailed lifecycle information about a tracer and its spans - to the Go tracer. It can be enabled via the MetaEventLogging flag in options. This option is not suitable for production environments as it generates a significant amount of spans.

austinlparker commented 5 years ago

Big note: This PR also removes all thrift support from the library.

austinlparker commented 5 years ago

@MatthewDolan We could, but we don't implement the DevMode flag in Thrift so this one would be kinda hacky.

iredelmeier commented 5 years ago

Yeah, I agree with @MatthewDolan that it feels like Thrift should be removed independently. I can open a separate PR to do that as a first step.

austinlparker commented 5 years ago

Nah, I can open one real quick @iredelmeier

austinlparker commented 5 years ago

@iredelmeier @MatthewDolan see #189

austinlparker commented 5 years ago

@iredelmeier @MatthewDolan @jmacd The separate thrift PR has been merged and this one is clean for review.