search

lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go
https://lightstep.com
MIT License
98 stars 54 forks source link

Add B3 header support #224

Closed chadbrad closed 4 years ago

chadbrad commented 4 years ago

Please add B3 header support :)

Please see this doc for the problem statement and specifics: https://docs.google.com/document/d/1ukvnSoXkavcojlVXpCRzep8PS_guXly_NbbhHIDgbFY/edit

This is high priority task, we need this ASAP. Please note the spec also covers trace-context and envoy support, but those are lower priority and captured in separate git issues.

CC @tedsuo

ledor473 commented 4 years ago

@codeboten is there any particular reason why Propagator in options.go is a String and directly the underlying structure you're converting the String to?

It makes it pretty hard to extend the capability of the Go tracer compared to the Java and NodeJS implementation.

The current implementation also doesn't allow to have multiple propagators (B3 + LS) at the same time to ease the migration from one to the other.

codeboten commented 4 years ago

@ledor473 thanks for the quick feedback! This was an oversight on my part and I created issue #238 to track the work to update this. I'll see about getting a PR reviewed today.

ledor473 commented 4 years ago

That's awesome! Thanks @codeboten 👍

codeboten commented 4 years ago

Here's the PR https://github.com/lightstep/lightstep-tracer-go/pull/239