search

lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go
https://lightstep.com
MIT License
98 stars 54 forks source link

Added new constructor for tracer that propagates error. #228

Closed bwplotka closed 4 years ago

bwplotka commented 4 years ago

Fixes https://github.com/lightstep/lightstep-tracer-go/issues/226

I also made error handling consistent for NewTracer - now it emits event only.

Overall I would suggest totally removing the emit event logic. It is not the best idea to have a global logger, especially for the library: it might cause issues if someone wants some flexibility (e.g running two tracers with different loggers.). Anyway, not a blocker for us here (:

Signed-off-by: Bartek Plotka bwplotka@gmail.com

bwplotka commented 4 years ago

Any ideas what's wrong with this test?

iredelmeier commented 4 years ago

Hi @bwplotka! The test problem seems to be unrelated to your change.

@codeboten just added #229, which should mitigate the timeout issue.

antonio commented 4 years ago

@iredelmeier @codeboten is there a timeline for a new release that includes this patch?

codeboten commented 4 years ago

@antonio hopefully looking at releasing before the end of the week

antonio commented 4 years ago

@codeboten awesome, thanks.