Closed bwplotka closed 4 years ago
Any ideas what's wrong with this test?
Hi @bwplotka! The test problem seems to be unrelated to your change.
@codeboten just added #229, which should mitigate the timeout issue.
@iredelmeier @codeboten is there a timeline for a new release that includes this patch?
@antonio hopefully looking at releasing before the end of the week
@codeboten awesome, thanks.
Fixes https://github.com/lightstep/lightstep-tracer-go/issues/226
I also made error handling consistent for
NewTracer
- now it emits event only.Overall I would suggest totally removing the emit event logic. It is not the best idea to have a global logger, especially for the library: it might cause issues if someone wants some flexibility (e.g running two tracers with different loggers.). Anyway, not a blocker for us here (:
Signed-off-by: Bartek Plotka bwplotka@gmail.com