Closed codeboten closed 4 years ago
closes #239
@iredelmeier I think you're right, the plan was to eventually implement a PropagatorStack to support multiple propagators as the java implementation: https://github.com/lightstep/lightstep-tracer-java-common/blob/master/common/src/main/java/com/lightstep/tracer/shared/PropagatorStack.java
@codeboten I think my understanding is the same as yours re: Java and C#? That is, a PropagatorStack is still a Propagator, but it's implemented as an array of n propagators.
The split across different propagator formats makes this a bit more painful... :/
Right, the difference being with the PropagatorStack, the format has to be specified at creation, where as with this implementation, which is similar to the javascript/ruby implementations, a map of formats can be specified and propagators for each format configured.
I suggest merging this change, and in a later change providing an implementation of the PropagatorStack to support multiple propagators per format.
Added a PropagatorStack to support multiple formats.
Good question, we could support something like
propagators:
http_headers:
ls
b3
text_map:
ls
binary:
binary
Although that wouldnt account for custom propagators
This enables users to configure custom propagators.
Signed-off-by: Alex Boten aboten@lightstep.com