search

lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go
https://lightstep.com
MIT License
98 stars 54 forks source link

fix zipkin trace id #262

Closed sokalauvalery closed 3 years ago

sokalauvalery commented 3 years ago

Port of https://github.com/lightstep/opentelemetry-exporter-go/commit/60b61487ed3e7c0ea66a5589ea0ed35795a75df3 commit

There are tracing systems which are not capable of propagating the entire 16 bytes of a trace-id. For better interoperability between a fully compliant systems with these existing systems, the following practices are recommended: When a system creates an outbound message and needs to generate a fully compliant 16 bytes trace-id from a shorter identifier, it SHOULD left pad the original identifier with zeroes. For example, the identifier 53ce929d0e0e4736, SHOULD be converted to trace-id value 000000000000000053ce929d0e0e4736. When a system receives an inbound message and needs to convert the 16 bytes trace-id to a shorter identifier, the rightmost part of trace-id SHOULD be used as this identifier. For instance, if the value of trace-id was 234a5bcd543ef3fa53ce929d0e0e4736 on an incoming request, tracing system SHOULD use identifier with the value of 53ce929d0e0e4736.

kayousterhout commented 3 years ago

Thank you for fixing this!

sokalauvalery commented 3 years ago

@kayousterhout thank you for merge! Can you please "release" new version with this patch?

kayousterhout commented 3 years ago

We will release a new version within the next day - hoping to get one more change in first!

sokalauvalery commented 3 years ago

Cool, thank you!

sokalauvalery commented 3 years ago

@kayousterhout , any updates about the release? )

kayousterhout commented 3 years ago

This is now released!