search

lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go
https://lightstep.com
MIT License
98 stars 54 forks source link

LS-21346: lightstep-tracer-go: generate uint64 trace IDs, not int64 #267

Closed neena closed 3 years ago

neena commented 3 years ago

R: @codeboten CC: @lightstep/team-ingest

We discovered that the tracer is generating int64 trace IDs and converting them to uint64s, which means we're only using half of the trace ID space! This PR makes it so we actually generates random uint64 trace IDs. (This should halve our probability of trace ID collisions).

neena commented 3 years ago

@codeboten did you get a chance to look at this? do you have any concerns, or can I go ahead with this?