search

lightstep / lightstep-tracer-go

The Lightstep distributed tracing library for Go
https://lightstep.com
MIT License
98 stars 54 forks source link

Update gopsutil to v3.21.3 #288

Closed aashishkapur closed 2 years ago

aashishkapur commented 2 years ago

I'm getting the following warning when building a package depending on lightstep-tracer-go: ../../pkg/mod/github.com/shirou/gopsutil/v3@v3.21.2/cpu/cpu_darwin_cgo.go:13:5: warning: 'TARGET_OS_MAC' is not defined, evaluates to 0 [-Wundef-prefix=TARGETOS]

We can fix this by upgrading gopsutil, see https://github.com/shirou/gopsutil/pull/1042

aashishkapur commented 2 years ago

@codeboten - mind triggering CI for this branch? Looks like I don't have permissions

aashishkapur commented 2 years ago

@codeboten friendly bump on this PR!

codeboten commented 2 years ago

re-opening to trigger circle ci. not sure why the status didnt report here.

aashishkapur commented 2 years ago

Looks like that did it - thanks! Is there anything I can do to get this merged in?

aashishkapur commented 2 years ago

Could I get your review on this PR @codeboten?