Closed malafeev closed 4 years ago
Thanks for the PR @malafeev
What happens if the user uses the SA with the new bundle, and uses a grpc
version different to the one we use?
And yes, it sounds like we will most likely need to do some extra digging into the grpc
part. Historically handling of different grpc
versions has been the most painful thing. okhttp
shading is just a nice thing to have.
@carlosalberto grpc should be shaded otherwise user can get incompatible grpc versions in classpath. Yes, I agree, we need to find a solution for proper grpc shading because straightforward shading doesn't work.
@carlosalberto I fixed shading of grpc and netty :)
243
what I found is that it's critical to test jre-bundle with real application. if I shade
io.netty
then tracer started but spans are not sent. Although unit tests passed. if I shadeio.grpc
then tracer failed to start. Although unit tests passed. therefore I shade onlyokhttp
also it's important to verify that configured tracer collector is picked up (grpc or okhttp). I did it manually debugging test application and changing configuration. Without my changes inCollectorClientProvider
grpc collector is never picked up.so it's quite confusing that unit tests cannot verify functionality and manual testing with some debugging is required.