search

lightstep / lightstep-tracer-javascript

Lightstep distributed tracing library for Node.js and the browser
https://lightstep.com
MIT License
77 stars 66 forks source link

Error when running in WebWorker #137

Closed felixfbecker closed 5 years ago

felixfbecker commented 5 years ago

The library crashes the WebWorker at this position: https://sourcegraph.com/github.com/lightstep/lightstep-tracer-javascript@789482ac598be711c6439c38553df52d47141273/-/blob/src/imp/platform/browser/options_parser.js#L6:19

Because it tries to access the DOM, which is isn't available in a WebWorker.

austinlparker commented 5 years ago

Thanks for opening this issue - do you have a small repro case you can share?

felixfbecker commented 5 years ago

Sure, just start a WebWorker and in it, load the lighstep-tracer library. Here's a fiddle: https://jsfiddle.net/y7xeujoz/7/

Output in Firefox (most helpful/specific error message):

image

Output in Chrome:

image

Output in Safari:

image

austinlparker commented 5 years ago

Cool, thanks!