search

lightstep / lightstep-tracer-javascript

Lightstep distributed tracing library for Node.js and the browser
https://lightstep.com
MIT License
77 stars 66 forks source link

implement plugin for fetch #156

Closed fastfrwrd closed 5 years ago

fastfrwrd commented 5 years ago

Why: we want a similarly seamless experience for use of native fetch tracing as is available via instrument_xhr. Though some polyfills have existed for some time, many browsers now directly implement fetch without any XMLHttpRequest involved. For those cases, this plugin will be necessary.

We mimicked the instrument_xhr plugin for consistency's sake. We are testing this plugin within our infrastructure with a fork of this project.

austinlparker commented 5 years ago

Cool, thanks for the contribution! We'll take a look at it but on first glance it seems solid.

fastfrwrd commented 5 years ago

Hi @austinlparker, thanks for reviewing! Are you planning to wait for a release to merge?

austinlparker commented 5 years ago

Sorry, travel week for me and I've been in a million meetings. I can go ahead and merge now.