search

lightstep / lightstep-tracer-javascript

Lightstep distributed tracing library for Node.js and the browser
https://lightstep.com
MIT License
77 stars 66 forks source link

updated thrift version to 0.12.0, removes security vulnerability #171

Closed nw closed 5 years ago

nw commented 5 years ago

See CVE: https://nvd.nist.gov/vuln/detail/CVE-2018-11798

This removes security warnings for end users.

Tests pass with changes

austinlparker commented 5 years ago

Thanks for opening this - out of curiosity, did you test it locally? We've had some gotchas in the past with thrift updates breaking things.

austinlparker commented 5 years ago

I tested this out locally and things seem fine, so I'll go ahead and merge.