search

lightstep / lightstep-tracer-javascript

Lightstep distributed tracing library for Node.js and the browser
https://lightstep.com
MIT License
77 stars 66 forks source link

Update typing on inclusion/exclusion patterns to match docs #188

Closed danrwhitcomb closed 4 years ago

danrwhitcomb commented 4 years ago

The typings for the inclusion/exclusion patterns are currently any. If you use a string[] rather than a RegExp[] - which I tried doing - right now, your app can't actually make network requests - according to my local testing.

This brings the typings in line with the documentation that says these options should all be RegExp[]

bg451 commented 4 years ago

Awesome, thanks!