Revert "Remove protobufjs devDependency (#197)"

lightstep / lightstep-tracer-javascript

Lightstep distributed tracing library for Node.js and the browser

https://lightstep.com

MIT License

77 stars 66 forks source link

Revert "Remove protobufjs devDependency (#197)" #208

Closed iredelmeier closed 4 years ago

iredelmeier commented 4 years ago

Oddly, removing the protobufjs dev dependency seems to be the cause of #207.

To test the fix, I've made a quick repro repo with steps.

MikeGoldsmith commented 4 years ago

Could we test just removing the protobudjs dev-dependency and revert the module.export? There are other changes that will get reverted if we revert the whole PR.

iredelmeier commented 4 years ago

Closing in favour of #209. Apparently our webpack browser build pulls in dist, and so there was a funky lib and/or dist somewhere along the way? 🤨