fix: 'method' was always GET. simplify _shouldTrace.

lightstep / lightstep-tracer-javascript

Lightstep distributed tracing library for Node.js and the browser

https://lightstep.com

MIT License

77 stars 66 forks source link

fix: 'method' was always GET. simplify _shouldTrace. #217

Closed kirbysayshi closed 4 years ago

kirbysayshi commented 4 years ago

Hello! I found a bug where most traces were reported as GET, even when the incoming request was POST. This should fix the bug by always using the recreated Request object. It also cuts down on the conditionals. I made two other simplifications, but will address them inline!

kirbysayshi commented 4 years ago

@ODEit I think this is ready to go!

charud commented 4 years ago

@sbaum1994 we updated the PR to remove the username/password tags. let us know if you think we can proceed to merge this fix.

charud commented 4 years ago

@sbaum1994 it doesn't seem like I'm able to merge this, would you be able to? thanks!