search

lightstep / lightstep-tracer-javascript

Lightstep distributed tracing library for Node.js and the browser
https://lightstep.com
MIT License
77 stars 66 forks source link

Upgrade eslint #218

Closed kirbysayshi closed 4 years ago

kirbysayshi commented 4 years ago

During my other PR, I discovered that although --fix was being passed to eslint, the version installed in the project was too old to know about the argument! So I updated to newest eslint and friends, and made whatever minimal code changes (or disabled rules) were necessary to remove all errors, as well as actually ran --fix, which was the majority of the fixes :D

Note: This was based off of my other PR branch (https://github.com/lightstep/lightstep-tracer-javascript/pull/217). Once that other PR is merged I will rebase off of master to remove pulling in those changes too.

kirbysayshi commented 4 years ago

Ok, aside from the question of opentracing being a peerDep, I think this is ready for review / merge!

I'll leave the peerDep question up to the maintainers. I'm not certain how this library is intended to be used regarding different versions of opentracing. And just to clarify, if opentracing is supposed to be swappable with another implementation, there is a lot more work to be done to allow that to happen since this library relies on opentracing at parse/init time.

kirbysayshi commented 4 years ago

Hey, is there anything else to be done here, or other questions?

iredelmeier commented 4 years ago

@kirbysayshi nope! Merged :)

kirbysayshi commented 4 years ago

Yay! Thanks for reviewing!

On Wed, Feb 19, 2020 at 6:38 PM Isobel Redelmeier notifications@github.com wrote:

@kirbysayshi https://github.com/kirbysayshi nope! Merged :)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/lightstep/lightstep-tracer-javascript/pull/218?email_source=notifications&email_token=AAAWFTZY4225FZOQDLIHWRTRDW7HPA5CNFSM4KILS622YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKEK3Y#issuecomment-588531055, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAWFT3DUNGLEUNTODVTLIDRDW7HPANCNFSM4KILS62Q .

-- Thanks, Drew