search

lightstep / lightstep-tracer-javascript

Lightstep distributed tracing library for Node.js and the browser
https://lightstep.com
MIT License
77 stars 66 forks source link

feat(TracerImpl): Optionally empty span buffer on max error streak #226

Closed dm03514 closed 4 years ago

dm03514 commented 4 years ago

refs #225

Adds a new option to completely clear the active spans on a certain number of contiguous errors. Clients can use their configured flush interval, combined with the max possible backoff & jitter, to calculate what to set this value to. This will allow them to calculate worst case "time between full empties" in the case of multiple errors in a row.

austinlparker commented 4 years ago

Code looks fine; Could you add a note in the README explaining the option and how to configure it?

dm03514 commented 4 years ago

Thank you @austinlparker I updated!

ishg commented 4 years ago

Thank you @austinlparker I updated!

@dm03514 I don't see the README update in the commit, could you kindly push? :)

dm03514 commented 4 years ago

@ishg sorry about that! Pushed