lightstep / lightstep-tracer-javascript

Lightstep distributed tracing library for Node.js and the browser
https://lightstep.com
MIT License
77 stars 66 forks source link

chore: auto release based on tag #251

Closed obecny closed 4 years ago

obecny commented 4 years ago

I have closed the PR with upgrading dependencies as it seems there was some issue with the speed of creating and closing spans - test were failing

obecny commented 4 years ago

One thing which left is to decide if the deployment should be done using the approach I used from previous or keep the one that existed in Makefile @mwear ?

mwear commented 4 years ago

We would like to changeover to tag based deploys, which I just tried out on opentelemetry-exporter-js and it worked great! We'll need to update our internal instructions accordingly.

mwear commented 4 years ago

For the record. The make publish task will continue to work the way it always has, but the actual npm deploy will happen on circle (instead of locally).