Use native BigInt instead of hex2dec.

lightstep / lightstep-tracer-javascript

Lightstep distributed tracing library for Node.js and the browser

https://lightstep.com

MIT License

77 stars 66 forks source link

Use native BigInt instead of hex2dec. #265

Closed dafortune closed 3 years ago

dafortune commented 3 years ago

There are some performance issues associated with usgin hex2dec to manage big numbers, this PR uses hex2dec if native implementation is not available, otherwise it goes with BigInt approach which has shown to have a better performance.

ishg commented 3 years ago

LGTM. Will wait for @mwear 's final approval before merging.

mwear commented 3 years ago

This was released in v0.31.0: https://www.npmjs.com/package/lightstep-tracer/v/0.31.0.