search

lightstep / lightstep-tracer-objc

The Lightstep distributed tracing library for Objective-C and Swift
https://lightstep.com
MIT License
11 stars 9 forks source link

[still testing] fix crash #36

Closed supermarin closed 7 years ago

supermarin commented 7 years ago

We're observing a crash in production since ~3 weeks ago. It's not happening too often, and most likely it happens after the app recovers from background and drains the autorelease pool on the main runloop.

I'm still confirming these are all the fixes needed.

bhs commented 7 years ago

FWIW, I have no great objections to this PR and am happy to merge it (i.e., they won't make anything any worse). It sounds like you are unsure that these fixes are in fact necessary. Let me know what you'd like to do... since I can't reproduce the failure it's hard for me to have a strong opinion :-/

Thanks.

supermarin commented 7 years ago

@bensigelman looking at the code this seems to me like the cause, but I haven't been able to reproduce the crash. Since we haven't bumped the lightstep pod version yet, it might make sense to try a bit more and confirm. Otherwise feel free to merge, there's no reason these properties shouldn't be strong.

bhs commented 7 years ago

@supermarin makes sense. I'll merge (why not?).