lightstep / lightstep-tracer-php

The Lightstep distributed tracing library for PHP
https://lightstep.com
MIT License
13 stars 15 forks source link

Fix http_proto sending child spans #44

Closed MikeGoldsmith closed 4 years ago

MikeGoldsmith commented 4 years ago

Fixes #36.

This PR allows child spans to be seen in the LightStep App. Child spans were not visible previously because the same span ID was used for all span's within the same trace, so only the parent was reported correctly.

After allowing spans to be reported, it was seen that parent and all child spans had the same start time. This was because the calculation from micros to nanos was incorrect.

The following fixes are included:

This also raised the issue of PHP not supporting unsigned int 64's (even int 64 can't be guaranteed). Further details in #43.