lightstep / servicenow-cloud-observability-datasource

ServiceNow Cloud Observability (formerly Lightstep) telemetry datasource for Grafana
Apache License 2.0
6 stars 3 forks source link

Update: Fix plugin configs resetting #11

Closed DHedgecock closed 1 year ago

DHedgecock commented 1 year ago

What does this PR do?

Updates the plugin development resources to fix configs resetting anytime the Docker container is restarted.

Current behavior

Currently the datasource is automatically setup using the provisioning/datasources/lightstep.yaml file, which means there's a zero setup required workflow IF you include your Lightstep API key in your shell environment AND you're using either the lightstep-public,lightstep-staging (which is unlikely).

If you're not using the LightStep org org lightstep-public,lightstep-staging projects, then whatever org name and project name are configured is reset to the default values in provisioning/datasources/lightstep.yaml anytime the Docker container is restarted. This means if you're using a project other than lightstep-public,lightstep-staging you have to re-setup the datasource every time you start it.

Updated behavior

The datasource is no longer automatically provisioned, so the initial setup includes an additional step of adding the plugin. However once the plugin is configured the settings are now successfully preserved across container restarts 🎉