Cleaning up some repo warnings to address:
commenting
removing unused parameters host and topoinline
changing a slice declaration to nil
renamed minand max to minimum andmaximum to eliminate the collision warnings with builtin functions
What is the new behavior?
Behavior is the same, just cleaned up some warnings
Pull request checklist
Please check if your PR fulfills the following requirements:
[x] Tests(make test) for the changes have been added (for bug fixes / features) and pass
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Lint (make lint) has passed locally and any fixes were made for failures
Pull request type
Please check the type of change your PR introduces:
[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):
Does this introduce a breaking change?
[ ] Yes
[x] No
Other information
I was going to update the deprecated rand.Seed usage but after starting this I think it should be it's own PR due to the amount of work it will be. We have LS-60180 for TODO comments.
What is the current behavior?
Cleaning up some repo warnings to address: commenting removing unused parameters
hostandtopoinlinechanging a slice declaration to nil renamedminandmaxtominimumandmaximumto eliminate the collision warnings with builtin functionsWhat is the new behavior?
Behavior is the same, just cleaned up some warnings
Pull request checklist
Please check if your PR fulfills the following requirements:
make test) for the changes have been added (for bug fixes / features) and passmake lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information
I was going to update the deprecated rand.Seed usage but after starting this I think it should be it's own PR due to the amount of work it will be. We have LS-60180 for TODO comments.