search

lightswitch05 / foscam-client

Node client sdk for current HD foscam cameras that stream H.264 like the FI9821W, FI9831P, etc..
https://lightswitch05.github.io/foscam-client
MIT License
45 stars 15 forks source link

Config setters should accept a config object #2

Closed vitosamson closed 9 years ago

vitosamson commented 9 years ago

I just accidentally overwrote my motion detection config because I only passed one arg to .setMotionDetectConfig(). Accepting an object would allow the user to get the config from the getter, update a specific config item, then pass that object back to the setter.

lightswitch05 commented 9 years ago

Yes, I would like to do this with all the getters and setters, but I haven't had time to yet. Pull requests welcome

vitosamson commented 9 years ago

I can start taking a crack at this. How do you feel about splitting up foscam.js into multiple files, organized similarly to the API PDF (AV functions, user account, PTZ control, etc)?

lightswitch05 commented 9 years ago

That is fine with me, just try to jsdoc everything. Long-term I would like to have a gulp-based build process with mocha tests that mock the actual calls. I've used this yeoman generator for other projects https://github.com/yeoman/generator-node

lightswitch05 commented 9 years ago

Closed by #3