search

lightswitch05 / hosts

Hostfile blocklist for ads and tracking, updated regularly
https://www.github.developerdan.com/hosts/
Apache License 2.0
1.51k stars 75 forks source link

Added spam / scam sites #331

Closed CMiksche closed 2 years ago

CMiksche commented 2 years ago

I've added some SPAM and Scam sites.

For the first few see https://blog.m5e.de/post/fighting-tinderplusplus-malware/, for the UCEPROTECT ones (last ones) see e.g. https://uceprotect.wtf/

lightswitch05 commented 2 years ago

Hey @CMiksche! Thanks for your contribution.

Unfortunately, I'm not able to accept pull requests to the repo, for two reasons:

  1. This is a downstream project from a private source hosts-management tool I use. It uses a database, ensures all domains resolve, a bunch of other things, and then generates these lists. So, if I merged this PR, it would just get overwritten in the next update
  2. I personally verify all the domains in the list. There is a lot in here without any information for me to be able to verify. Even if you did provide all that, it would still take a lot of time for me to review and verify, time that I really just don't have.

I love open source, submitting PRs, and having a bunch of contributors to a software project. I think block-lists aren't really great candidates for all that since everyone has their own opinion what should or should not be blocked. This is more of a personal project then a collaboration. I hope you understand. It's a very well done PR and I appreciate the time and effort you clearly put into it.

d1nuc0m commented 2 years ago

@CMiksche please avoid using UCEPROTECT's lists, they're at least controversial. See here and here (these links are on the UCEPROTECT's website).

CMiksche commented 2 years ago

@d1nuc0m Yeah, that's why I am adding the domains of the UCEPROTECT Project to this blocklist ;-)