lightswitch05
commented
9 years ago This goes along the same lines as the proposed solution for #14. But how do we allow users define these textExtraction / formatting functions? Accepting a single callback would not be useful, different columns contain different data. So, we'd have to allow a callback per-column. But also, what if someone only wanted a callback for one specific cell that is different then all the others?
If you read #14, @Mottie suggests doing something like this where the callback is defined using a selector. I really like this because it allows the user to be as flexible or rigid with the callbacks as they like. Before looping through the table and finding values, we could store the user's callback function in all the cells via the data method:
for (index=0; index < callbacks.length; ++index) {
table.find(callbacks[i].selector).data('tableToJsonCallback', callbacks[i].callbackFunction);
}When getting the values of each cell, we could check to see if it has a tableToJsonCallback data attached to it, if it does, we could send the the entire cell contents to it - maybe even the header name & cell index, and use whatever it returns as the value:
var cellValues = function(cellIndex, cell) {
var value, result;
var override = $(cell).data('override');
if ( opts.allowHTML ) {
value = $.trim($(cell).html());
} else if ( typeof $(cell).data('tableToJsonCallback') === 'function' ) {
value = $(cell).data('tableToJsonCallback')(cell, cellIndex);
} else {
value = $.trim($(cell).text());
}
result = notNull(override) ? override : value;
return result;
};If you are willing to add this feature & tests for it, it would be a very powerful feature
station384
siamkreative
Mottie
One issue I have come across is when a table header has an odd name example 'Col 1 / ID'
this is valid it would render as {'Col 1 / ID': 'someValue'}
but parsing it is where it becomes an issue. It can be used in JavaScript by calling it as var col1 = parsedJson['Col 1 / ID']; but you can't call it as var col1 parsedJson.Col 1 / ID;
This issue is even more pronounced in other languages, C#, Java, Tcl.
The person could filter the JSON text and clean the property names, but that would be a lot of logic that would have to be implemented, or done in a regex that is beyond me.
What I propose is adding a new option. if the option is null or undefined, the current behavior continues. But if there is a function object, we call that function and pass in the string that is going to be set as the property, the return value from the function is what we use as the property.
something like this.
This gives the option to the end user to filter text, process it, map it if they want.
I can implement it.