lightswitch05 / table-to-json

Serializes HTML tables into JSON objects.
http://lightswitch05.github.io/table-to-json/
MIT License
756 stars 172 forks source link

Bug in Demo #33

Closed georgeu2000 closed 7 years ago

georgeu2000 commented 7 years ago

Apparently there is a bug on http://www.developerdan.com/table-to-json/.

When I click convert,

image

This seems strange because the first row's points are 50, but the JSON is "disqualified".

Also, the 3rd header is Points, but JSON is "Score".

lightswitch05 commented 7 years ago

Look at the HTML. This example is showing options to modify results, it is not a bug.

georgeu2000 commented 7 years ago

In that case, you may want to explain that on the page. It seems to suggest that options are not being used:

  var table = $('#example-table').tableToJSON(); // Convert the table into a javascript object
  console.log(table);
  alert(JSON.stringify(table));
lightswitch05 commented 7 years ago

Yes, I completely agree. Pull requests welcome!

georgeu2000 commented 7 years ago

I wanted to update the docs, but I don't see how to do so. The issue is not on the readme in the repo. The issue is on http://www.developerdan.com/table-to-json/.

Mottie commented 7 years ago

Try the gh-pages branch.

georgeu2000 commented 7 years ago

@Mottie - Thanks.