search

lightswitch05 / table-to-json

Serializes HTML tables into JSON objects.
http://lightswitch05.github.io/table-to-json/
MIT License
756 stars 172 forks source link

BUGFIX: ignoreEmptyRows #54

Closed cn-tools closed 4 years ago

cn-tools commented 4 years ago

ignoreEmptyRows now also considers ignoreColumns, onlyColumns, extractor and textExtractor

Bugfix:: #53

I'm not sure if it is the best solution, but it works for me.

lightswitch05 commented 4 years ago

Looks like the linter is still failing: ^ Expected '!==' and instead saw '!='.: https://github.com/lightswitch05/table-to-json/pull/54/commits/8307a3744c676506af25d9953926134824b4adee

lightswitch05 commented 4 years ago

Merged into develop branch. I can fix the remaining issues from there. Thank you for your contribution @cn-tools! (I've gotta say, I thought I was done with this tool 😆 )