search

lighttiger2505 / lab

lab is a cli client of gitlab like hub
MIT License
91 stars 9 forks source link

fix build #42

Closed mattn closed 6 years ago

lighttiger2505 commented 6 years ago

@mattn thanks for contribution.

but your commit is not fix build. Could you tell me why you need to fix this?

/tmp/go-build513997367/github.com/lighttiger2505/lab/gitlab/_test/_obj_test/client.go:55:2: cannot use jobs (type []gitlab.Job) as type []*gitlab.Job in return argument

https://travis-ci.org/lighttiger2505/lab/builds/369107323?utm_source=github_status&utm_medium=notification

lighttiger2505 commented 6 years ago

The result of building your branch on my machine is as follows

$ go build ./...
# github.com/mattn/lab/gitlab
gitlab/client.go:47:2: cannot use jobs (type []gitlab.Job) as type []*gitlab.Job in return argument
# github.com/mattn/lab/commands
commands/pipeline.go:126:45: cannot use jobs (type []"github.com/mattn/lab/vendor/github.com/xanzy/go-gitlab".Job) as type []*"github.com/mattn/lab/vendor/github.com/xanzy/go-gitlab".Job in argument to jobOutput
mattn commented 6 years ago

Ah, sorry. In my local repository, go-gitlab is master branch. And I built lab with go build. It seems that go-gitlab add breaking changes at https://github.com/xanzy/go-gitlab/pull/364 . So please close this PR.

lighttiger2505 commented 6 years ago

@mattn Understood. I am happy to receive a pull request from a respecting person.

mattn commented 6 years ago

FYI, v0.9.0 is tagged in go-gitlab just now.

lighttiger2505 commented 6 years ago

Thank you for teaching me.

Since I upgraded go-gitlab, I will merge your pull request.