search

lighttransport / nanort

NanoRT, single header only modern ray tracing kernel.
MIT License
1.07k stars 89 forks source link

Remove inv_dir and dir_sign from Ray class or utilize them #49

Closed Tyler799 closed 4 years ago

Tyler799 commented 4 years ago

Currently, the comments say they are filled internally. This is incorrect, these members are never either filled or read. Instead, Traverse(), MultiHitTraverse(), and ListNodeIntersections() all create these on the fly to pass to IntersectRayAABB().

Either they should be removed or used, having them there is confusing if they arent used.

syoyo commented 4 years ago

Thanks! inv_dir and dir_sign was used before nanort introduced Intersector template class.

I have just removed it.

Tyler799 commented 4 years ago

You're welcome, thanks for the quick reply.