FIXED: issue #4 - Githubissues

lightvue / slidev-theme-light-icons

A light and Elegant theme for Slidev

https://slidev.icons.lightvue.org/

46 stars 32 forks source link

Open htharoldht opened 2 years ago

htharoldht commented 2 years ago

Fix the bug that the page does not update after using dynamic-image layout #4

MatthewCushing commented 2 years ago

Any update on this?

htharoldht commented 2 years ago

Only one root node <div></div> is added, which can fix #4

MatthewCushing commented 2 years ago

Just a heads up. This works, you just didn't close the <div> tag on line 3. Put the closing > character on the div and the checks should pass

htharoldht commented 2 years ago

Got it, I'll pr again. Thanks

MatthewCushing commented 2 years ago

Odd that it failed. Something to do with Vite plugin 404'ing from Netlify

3:16:13 AM: [vite-plugin-remote-assets] Request failed with status code 404

Code works though 👍