lightyrs / tabler-rubygem

Rubygem for https://tabler.github.io
MIT License
82 stars 27 forks source link

make the include of tabler more choosable #4

Closed fanjieqi closed 6 years ago

fanjieqi commented 6 years ago

When I add smart_listing gem to my project, I found that there is a bug in smart_listing:

Uncaught TypeError: Cannot set property 'href' of undefined
    at smart_listing.self-c2127587124142c4ee0bd23f7389610c0eb0f8d979b5b110a24930a63c7be7ee.js?body=1:14
    at smart_listing.self-c2127587124142c4ee0bd23f7389610c0eb0f8d979b5b110a24930a63c7be7ee.js?body=1:652

My application.js is

//= require jquery
//= require jquery_ujs
//= require turbolinks
//= require_tree .
//= require tabler
//= require tabler.plugins
//= require smart_listing

I found that the two requirement of jQuery is the problem.

When I remove the jQuery, it works:

//= require jquery
//= require jquery_ujs
//= require turbolinks
//= require_tree .
//= require tabler/tabler
//= require tabler/vendors/bootstrap.bundle.min
//= require tabler/vendors/circle-progress.min
//= require tabler/vendors/jquery.sparkline.min
//= require tabler/core
//= require tabler.plugins
//= require smart_listing

Would you accept the pull request to make the include of tabler more choosable?