search

lightyrs / tabler-rubygem

Rubygem for https://tabler.github.io
MIT License
82 stars 27 forks source link

Font Awesome Icons not working #9

Closed drale2k closed 5 years ago

drale2k commented 6 years ago

Font Awesome icons can not be used for some reason. Feather and Flags work fine. When i try something like <i class="fa fa-toggle-left"></i> nothing is shown.

lightyrs commented 6 years ago

I did not implement font awesome for this gem. I encourage you or someone else to make a pull request. I will gladly merge it.

alexmorral commented 6 years ago

Wouldn't it be better if Font Awesome icons need to be installed separately? I mean, yes they could be on the gem as a dependency or even the css and svgs but maybe it's better if you install the icons that you want on your project manually: FontAwesome, Themify, etc.

krtschmr commented 5 years ago

@alexmorral i agree. dependencies for frontend are always a bad thing. escpecially since it's simply just a stylesheet tag into the CDN of fontawesome

lightyrs commented 5 years ago

Closing this with the understanding that fontawesome can be included as needed (but will not be a dependency of this project).