lightz96 / pe

0 stars 0 forks source link

Invalid location accepted for addevent command #7

Open lightz96 opened 4 years ago

lightz96 commented 4 years ago

Users are allowed to enter an invalid location addevent n/Bobby e/122 t/16112019-1405-1406-~. In this case, the location used is ~. Should only allow valid location.

image.png

nus-pe-bot commented 4 years ago

Team's Response

We reject this issue as stated it is stated in the user guide that the user can enter any value for location.

Screenshot 2019-11-17 at 3.26.14 PM.png

Rational: The purpose of TimeBook is to allow user to manage their NUS and non Nus events. It would defeat the purpose of TimeBook if we restrict the location of the events to be only in NUS(locations on NUS mods) or only can contain Alpha-Numeric values. There are valid locations on earth that contains non Alpha Numeric values(ie ISS/4-4). Hence we intentionally allow the user to enter any value for the location. I hope this answers your question.

In the situation you reject my rejection: I dropped the serverity to low as entering an unconventional location(non alpha numeric entry) does not affect any functionallity of TimeBook. Additionally, the select free time command will identify that this location is not supported by TimeBook will inform the user that it is not used in the computation of the closest common location.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low]. Originally [severity.High].

Reason for disagreement: [replace this with your reason]