Prebuilt binaries in app/src/main/assets

ligi / IPFSDroid

Android App for the InterPlanetary File System(IPFS)

GNU General Public License v3.0

304 stars 73 forks source link

Prebuilt binaries in app/src/main/assets #38

Open relan opened 5 years ago

relan commented 5 years ago

Hi,

F-Droid maintainer here. We can't update IPFSDroid to 0.12 because it contains prebuilt binaries in app/src/main/assets (named arm and x86). My guess is that it's free software and comes from https://github.com/ipfs/go-ipfs, but our policy requires it to be built from source to make sure it does not contain any proprietary bits. Could you provide some build instructions for go-ipfs binaries or even better integrate go-ipfs into IPFSDroid build system?

SalvatoreT commented 5 years ago

Here's @ligi's build script..

mkdir /tmp/workspace
cd /tmp/workspace/
export GOPATH=/tmp/workspace/
export PATH=$GOPATH/bin:$PATH
go get -d github.com/ipfs/go-ipfs
cd $GOPATH/src/github.com/ipfs/go-ipfs
make toolkit_upgrade
make deps
xgo -go 1.8.3 -ldflags "-s -w" --targets=android-16/* ./cmd/ipfs

relan commented 5 years ago

make toolkit_upgrade step gives me

make: *** No rule to make target 'toolkit_upgrade'.  Stop.

CHANGELOG.md says that this step was removed in "0.4.2 - 2016-05-17".

Also we need to use exactly the same go-ipfs version that you did, not just master. Which version was that?