search

ligi / PassAndroid

Android App to view passes
GNU General Public License v3.0
802 stars 135 forks source link

Document image inclusion in espass format #173

Open eternaltyro opened 6 years ago

eternaltyro commented 6 years ago

I downloaded the example passes from espass.it and I noticed that the files named strip.png and footer.png automatically find their places in the pass display when they are included in the container. As far as I can see, this is undocumented in the espass spec. I can help with documentation for this.

eternaltyro commented 6 years ago

Seems to be hardcoded here: https://github.com/ligi/PassAndroid/blob/2eae832bc0ccd6f90b79a0dde9af6d0cfb2f0f4c/android/src/main/java/org/ligi/passandroid/ui/UnzipPassController.kt

eternaltyro commented 6 years ago

Please include dimensions of images also.

eternaltyro commented 6 years ago

I raised the issue in espass project page too: https://github.com/esPass/espass.github.io/issues/8.

I'm leaving this open since it's partially related to PassAndroid app as well.