Open HarryJohnso opened 4 years ago
simontb
commented
4 years ago Thanks for your efforts. I prefer the "disconnected snackbar". I think it might be a good fit. Did you find time to experiment a bit in the meantime? I'd like to see a screenshot/video if availble.
The light snackbars don't look like they're highlighting content to me.
HarryJohnso
commented
4 years ago @simontb Do apologise for not getting back to you till now.
I did experiment with coloured snackbars but didn't look into the "disconnected snackbar". The "disconnected snackbar" might require a custom class, but I could wrong.
In the next week or two I'll do some investigating and report back.
HarryJohnso
commented
4 years ago @simontb @ligi Do apologise again for not getting back to you on this now. I've been wrapped up in work.
I haven't exactly figured out how to implement a "disconnected snackbar" in Android. I have been working with Flutter for the last few months and found out that it's referred to as "Floating Behavior" that can be set in behavior property in Flutter's Snackbar class.
I thought this might be helpful.
In the next month or two I'll set some time aside to figure this out and I'll report back.
Hope you're both safe & well.
In the Pull Request I did https://github.com/ligi/PassAndroid/pull/229 @ligi recently mentioned the snackbars looked weird with the white navbar. I thought it might be better to make a new issue to discuss how best to approach it.
Anyway the first issue surrounding the snackbars looks weird with the white navbar in day theme.
One option could be changing the theming of the snackbars to a lighter colour in day theme. Not exactly like the image below but something a bit similar. I have seen light coloured snackbars in the past but can't exactly remember which apps, maybe Google Photos.
The other could be having a "disconnected snackbar" as seen below, which is featured here in Google's design documentation.
The other issue that I see with snackbars now is it looks weird with the Android 10 gestures as shown below when I temporarily apply the black navbar to the day theme. I feel maybe it might be better to implement the snackbars as "disconnected".
In the meantime I will experiment a bit with all this and show what I've come up with. Anyway @ligi and @simontb, I look forward to hearing both of your thoughts.