search

ligi / PassAndroid

Android App to view passes
GNU General Public License v3.0
809 stars 136 forks source link

Urgent: Feature Request - German "Deutschland Ticket" #480

Open openfnord opened 1 year ago

openfnord commented 1 year ago

The German "Deutschland Ticket" (Rail and bus pass for whole Germany for 49E/month) can be obtained as ticket.pkpass file, depending on vendor. So I successfully imported the ticket. Unfortunately the train conductor wants to see a moving logo somewhere above the QR code to make sure that an application is used and not a photo viewer. This is because some conductors can NOT check the ticket electronically and need to believe in the app. In order to avoid discussion, it would be nice to add a "sprite" that moves like the lamps of the knight rider car "k.i.t.t" from left to right and back with some bouncy acceleration on the way.

Ideally have settings: -moving sprite content (upload a picture or choose one of the logos that came with the pkpass file) -position of bouncing bar (up, down) -speed, acceleration of bouncing bar.

So one can just fake it to look as the conductors like it.

Maybe, they would not like this as a sprite: https://www.c3d2.de/images/shop/datenpiraten_1600x1200.jpg

Would be nice if someone adds this soon, and I would be able to provide an incentive for early implementation.

ligi commented 1 year ago

tbh. this does not really make sense to me - is there such an animation in the apple wallet - maybe even inside the pass?

ligi commented 1 year ago

Thanks to @openfnord I was able to look in the pkpass - but there is no animation in there as far as I can see. So now wondering where this is coming from. Really doubt apple is doing a special case animation just for Deutschland Ticket. Maybe someone with an iOS device can let me know how it looks there.

spaetz commented 1 year ago

Nahh, some transportation apps, such as the HVV (Hamburg) app and also the HVV issued web ticket frature such a moving logo. However, as that is nothing which is defined in the pkpass file (and indeed my web app offers a pkpass file for download), I don't think there is anything a pkpass viewer can do about this.

openfnord commented 1 year ago

Hi all,

AS I explained.

The viewer shall just habe a feature to animate some Logo one can install and move it in knight rider car kitt fashion left and right.

Just a moving sprite as you know from 1980s action games. Shoot the BVG logo as an easter egg would be fine too:-)

It is just a gimmick to be displayed and is not connected to the ticket at all except that one can use gimp or so in order to extract a {my transport provider} logo tone put into the animator.

This is not so difficult to understand, I hope

Cheers

Luja

On July 2, 2023 7:57:04 PM GMT+02:00, Sebastian Spaeth @.***> wrote:

Nahh, some transportation apps, such as the HVV (Hamburg) app and also the HVV issued web ticket frature such a moving logo. However, as that is nothing which is defined in the pkpass file (and indeed my web app offers a pkpass file for download), I don't think there is anything a pkpass viewer can do about this.

-- Reply to this email directly or view it on GitHub: https://github.com/ligi/PassAndroid/issues/480#issuecomment-1616751151 You are receiving this because you were mentioned.

Message ID: @.***> -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

openfnord commented 1 year ago

Hi all,

I am now sending you the content of my pkpass file, which is a pkzip file. Here you FIND the logos of the transport authority RMV. They have alpha and can be animated at ease. So please add an option to show all logos (png files) found in the pkpass file and choose one for the animation:

<-RMV----------> <-----RMV------> <--------RMV---> <----------RMV-> <-----------RMV> <--------RMV---> <-----RMV------> <-RMV----------> In the json file I removed my name and replaced it with a generic one. feel free to play with it. Am Sonntag, Juli 02, 2023 19:57 CEST, schrieb Sebastian Spaeth ***@***.***>:     Nahh, some transportation apps, such as the HVV (Hamburg) app and also the HVV issued web ticket frature such a moving logo. However, as that is nothing which is defined in the pkpass file (and indeed my web app offers a pkpass file for download), I don't think there is anything a pkpass viewer can do about this. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "https://github.com/ligi/PassAndroid/issues/480#issuecomment-1616751151", "url": "https://github.com/ligi/PassAndroid/issues/480#issuecomment-1616751151", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]***>  
openfnord commented 1 year ago

Hi all,

how to find the logos:

~/nas_take/1traveldata/passandroid] └─$ unzip rmv0723.pkpass                           Archive:  rmv0723.pkpass  extracting: @.          extracting: @.          extracting: thumbnail.png             extracting: pass.json                 extracting: @.               extracting: @.               extracting: logo.png                  extracting: @.               extracting: @.               extracting: icon.png                  extracting: manifest.json             extracting: signature                                          

So there is logo.png and there are enlarged versions of the logo @2x, 3x.png if you animate logo.png it should be sufficient.

<-logo.png----------> <-----logo.png------> <--------logo.png---> <----------logo.png-> <-----------logo.png> <--------RMV---> <-----RMV------> <-RMV----------> Thanks Am Dienstag, Juli 04, 2023 07:25 CEST, schrieb "luja" ***@***.***>:  Hi all, I am now sending you the content of my pkpass file, which is a pkzip file. Here you FIND the logos of the transport authority RMV. They have alpha and can be animated at ease. So please add an option to show all logos (png files) found in the pkpass file and choose one for the animation: <-RMV----------> <-----RMV------> <--------RMV---> <----------RMV-> <-----------RMV> <--------RMV---> <-----RMV------> <-RMV----------> In the json file I removed my name and replaced it with a generic one. feel free to play with it. Am Sonntag, Juli 02, 2023 19:57 CEST, schrieb Sebastian Spaeth ***@***.***>:     Nahh, some transportation apps, such as the HVV (Hamburg) app and also the HVV issued web ticket frature such a moving logo. However, as that is nothing which is defined in the pkpass file (and indeed my web app offers a pkpass file for download), I don't think there is anything a pkpass viewer can do about this. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "https://github.com/ligi/PassAndroid/issues/480#issuecomment-1616751151", "url": "https://github.com/ligi/PassAndroid/issues/480#issuecomment-1616751151", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]***>    
ChrisPHL commented 4 months ago

Unfortunately the train conductor wants to see a moving logo somewhere above the QR code to make sure that an application is used and not a photo viewer.

Hello there, I personally would ask the train conductor for an explanation what he will assure with that. I would furthermore explain him/her that the only security results from the scanned QR-Code in combination with the ID-Card. Please think about the people that even have their "Deutschland-Ticket" as a plastic card. Where is the moving logo in this case? Concerning these thoughts I feel very high cost (development time) for very low use. Btw you could even create a moving gif-file that shows the logo bouncing or whatever you want and the ticket code.

kind regards Chris

openfnord commented 4 months ago

Note, train conductors are train conductors because they did not study computer science or learned something serious. So they get told by their instructors to check for certain things and if they are new and "strict" they will also ask for your ID card to reveal the name printed on the ticket, hoping to earn some extra honors having hunted down someone riding without a "valid" ticket. In order to have peace of mind just give them what they want.

I used pass android a lot and did not have too much discussions though, because there is too much chaos about the tickets and every transport authority rolling their own sh*t application. So they are not so strict as in the beginning.

Fun fact: If you enter a bus, operated by a communal bus service of a city or county, the bus driver "checks" the ticket. As the bus company operating for the transport authority of the city or the county does not buy the checking application or does not use them, the bus driver is instructed to "check" the ticket, by staring at the QR-code you present using your smart phone to the driver. If there is a valid from - to date and your name, he/she is happy.

So you can edit a passbook file with vi, enter your credentials and the valid period and use a invalid ticket, as they can not check it :-)

But "do not try this at home". Doing so may be a felony in Germany, but it depends on what you claimed, entering the bus. Ask your lawyer for legal advice before tying it, or have an additional valid ticket when trying this out.

spaetz commented 4 months ago

Can we please stop any condescending remarks about certain professions here? Declaring that conductors did not learn something serious is something that I find pretty offensive, and no I am no conductor. Thanks.

openfnord commented 4 months ago

It is just based on experience...

Regarding the bouncy logo, they want to be able to identify a screenshot. But one can have a tool to display a bouncing picture on a background picture, so this is no security feature at all. But it is more difficult to explain such stuff, again jobs are commonly done by people who qualify....

Cheers

On 17 May 2024 18:34:53 CEST, Sebastian Spaeth @.***> wrote:

Can we please stop any condescending remarks about certain professions here? Declaring that conductors did not learn something serious is something that I find pretty offensive, and no I am no conductor. Thanks.

-- Reply to this email directly or view it on GitHub: https://github.com/ligi/PassAndroid/issues/480#issuecomment-2117968245 You are receiving this because you were mentioned.

Message ID: @.***> -- Sent from my Android device with K-9 Mail. Please excuse my brevity.