search

ligi / PassAndroid

Android App to view passes
GNU General Public License v3.0
806 stars 135 forks source link

EAN-13 / GTIN codes #76

Closed DocSniper closed 8 years ago

DocSniper commented 8 years ago

Great to have 1D barcodes now, thanks.

I'm missing EAN-13 / GTIN codes that are used on European loyalty cards, like the Payback card or Deutschland card. Would be great if you could add this, thanks.

https://en.m.wikipedia.org/wiki/International_Article_Number_(EAN)

https://en.m.wikipedia.org/wiki/Global_Trade_Item_Number

ligi commented 8 years ago

Thanks for the suggestion!

ligi commented 8 years ago

so as far as I understood GTIN is encoded in EAN - so if I add EAN-13 we should be good?

DocSniper commented 8 years ago

Yes, I think EAN-13 coded barcodes will enable your app to cover a lot of loyalty cards.

ligi commented 8 years ago

Good to know - I don't use these loyalty cards so I was unaware of this.

ligi commented 8 years ago

EAN-13 Support is now in 3.0.9 which I jus uploaded to beta

DocSniper commented 8 years ago

Thank you very much, will test it soon.

DocSniper commented 8 years ago

Can you add rotation (like with PDF417) while displaying the big versions of EAN and the other non square barcode please. Thanks :-)

ligi commented 8 years ago

You mean in fullscreen?

DocSniper commented 8 years ago

Yes I think it's full screen, after one touches a barcode.

ligi commented 8 years ago

this issue is tracked here - will fix it soon - would be great if you could give feedback if it works for you once the change is released to beta: https://github.com/ligi/PassAndroid/issues/71

DocSniper commented 8 years ago

Thank you, I'll test and report :-)

ligi commented 8 years ago

is now in beta with 3.1.9

DocSniper commented 8 years ago

Still waiting for F-Droid ...

DocSniper commented 8 years ago

F-Droid finally updated to 3.2.0 and it seems to work fine now. Thank you.

ligi commented 8 years ago

thanks for reporting and testing!