search

ligi / PassAndroid

Android App to view passes
GNU General Public License v3.0
814 stars 136 forks source link

Usage of color information for boardingpasses. #86

Closed UmpPCPL closed 8 years ago

UmpPCPL commented 8 years ago

Hi

I would like to propose to start using color atributes from pass.json. Example. "foregroundColor": "rgb(51, 51, 51)", "backgroundColor": "rgb(255, 179, 0)", "labelColor": "rgb(102, 102, 102)",

Without this, graphics that include white color are totally invisible. I am enclosing screenshots of LOT Polish Airlines boarding pass from PassAndroid and application from competition. Also Lufthansa without correct background ( yellow ) looks worse.

I can send examples of boarding passes directly if it is needed. ( I dont want to attach them here )

Regards and thx for your work.

Michal

screenshot_2016-06-18-23-55-22

screenshot_2016-06-18-23-52-34

ligi commented 8 years ago

Can you send me the passes so I can have a look?

UmpPCPL commented 8 years ago

I have sent an email with examples attached. Let me know if you don't receive them.

ligi commented 8 years ago

Thanks so much - got them and it looks really helpful - especially as I met a designer at droidcon who suggested a redesign for flight-passes and having a good set of real passes to test with is really helpful to me.

ligi commented 8 years ago

LOT will really look nicer with the bgColor ;-) not yet sure about Lufthansa

device-2016-06-22-134607

I do not want the color behind the text as I have even seen passes with a very similar foreground and background color - then form follows function and I rather have high contrast on the text than a nicer icon. This is also important fot the upcoming day/night mode

UmpPCPL commented 8 years ago

Of course for Lufthansa it doesnt look well. Just one comment from my side. Please remember that pkpass format is mainly targeted towards Iphone users. It means that testing of pass issuers will be always done at iphone.

In my opinion you should handle color in identical ways us it is hadled by Apple Wallet. But of course it is up to you ;-)

ligi commented 8 years ago

yea - but this is not as trivial as it sounds - perhaps a color contrast is OK on all iphones - but on some ( cheap ) android phones the contrast is too low. I do not only write for high-end phones - I also welcome the lower end ones as I like poor people. Also I am not sure if apple will do day/night - lot of considerations here. I can't and also do not want to copy what apple has done. The passbook format has to die in the end - long live espass ;-) Also I think I found a solution - I will move the icon into the indicator on the right - I think this will look good and even give more space for text then.

ligi commented 8 years ago

this would be my suggestion device-2016-06-22-145821

ligi commented 8 years ago

Implemented it now simmilar to this - balanced the layout a bit more - will release with 3.2.1 as beta

device-2016-07-18-021920