Allow to customize the package name.

ligi / SnackEngage

Engage Users with a Snackbar to e.g. rate or translate the app

MIT License

62 stars 12 forks source link

Allow to customize the package name. #20

Closed johnjohndoe closed 7 years ago

johnjohndoe commented 7 years ago

This is useful if you use "applicationIdSuffix" for your "debug" build type but still want to test the store URL.

ligi commented 7 years ago

Sorry - but I do not like this change and I do not really see the benefit of it

johnjohndoe commented 7 years ago

It applies to the case when you set:

buildTypes {
    debug {
        applicationIdSuffix ".debug"

SnackEngage will not point to the correct Google Play location if invoked from a DEBUG build. It would be convenient to test snacks from DEBUG builds, too.

ligi commented 7 years ago

Yes I understand the intent - but my rule of thumb is to not pollute production code with code that is only for testing - and this is kind of what this is. Also then you might forget your override and have wrong links when you change the packagename. Liked your other PRs - but not this one - sorry.

johnjohndoe commented 7 years ago

Thank you. I can understand your decision.