search

ligi / SnackEngage

Engage Users with a Snackbar to e.g. rate or translate the app
MIT License
62 stars 12 forks source link

Version increase for release 0.19 #36

Closed johnjohndoe closed 5 years ago

johnjohndoe commented 5 years ago

There is a tag for 0.19 and I am able to download an artifact for that version because I directly depend on the Git tag which is referenced via JitPack:

implementation com.github.ligi.snackengage:snackengage-playrate:0.19

However, the version_name and version_code properties have not been changed from 0.18 to 0.19 resp. from 18 to 19. See https://github.com/ligi/SnackEngage/blob/0.19/build.gradle#L5-L6.

If this is an error please apply a "fix" before merging pull requests #34 and #35 so it will still be possible to depend on a library artifact which is based on SDK 27 and support library 27.1.1.

ligi commented 5 years ago

fixed by having version 0.20