DayNight mode

[ligi]

use the Appcompat 23.2 function so that users can switch between Day/Night/Auto - need a dark board background ( if anyone knows one with a fitting license let me know )

context: https://www.reddit.com/r/baduk/comments/4ajdjr/i_did_a_major_material_redesign_to_gobandroid/d11h14e

[JohnPablok]

There's a lot of wooden backgrounds here, although the resolution of the free options is a bit lacking but it might work: http://www.textures.com/browse/fine-wood/14119 I really like the attached one.

[ligi]

Looks great - is the licensing so that I can use it in a GPL app? Should I paint white lines on it?

[JohnPablok]

I think you should be okay using it, they even allow commercial videogames to use the textures. http://www.textures.com/terms_of_use.html In my opinion stay with the black lines, they look better than white.

[ligi]

IANAL but this sounds bad:

2.2 You are not permitted to:

f) release the Photos or derivative products with Photos under Open Source Licences.

[JohnPablok]

Mmm, that's right. Maybe you can use it as long as you don't release the image with the source code? Another option is just making the original gobandroid texture a bit darker.

[ligi]

I asked them via email

[ligi]

there was an (fast) answer:

Hi,

Releasing our images under an Open Source license is not allowed (even when the images are modified). So that would not be allowed.

Some developers choose to release the images under a separate (closed source) license, and the code under an Open Source license.

Kind regards,

Marcel www.textures.com

[JohnPablok]

Interesting! So it is possible as long as you don't host the picture on Github? Either way if you need help modifying the original gobandroid image I'll be glad to help.

[ligi]

Not hosting the image on github is bad - e.g. as it is a problem for CI-Servers. If you could try to modify the original image that would be great - I am good with Code - not so good with creating graphics

[JohnPablok]

Cool, I'm good with graphics and bad with code hehe! Where can I get the original image from?

[ligi]

https://github.com/ligi/gobandroid/blob/master/android/src/main/res/drawable/shinkaya.jpg

[JohnPablok]

I made two options, "black walnut" and "oak":

Black Walnut

I tried to make it "not as dark" so that the black lines of the board are still very visible, as well as the black font of the interface.

Oak (just because)

Edit: Made them a little bit less saturated, they looked very intense on my tablet. Edit2: For comparison, this is the shinkaya:

[ildar]

ср, 16 мар. 2016 г. в 23:29, John Pablok notifications@github.com:

Interesting! So it is possible as long as you don't host the picture on Github? Either way if you need help modifying the original gobandroid image I'll be glad to help.

Not true. Github can host non-free resources.

OSMand has non-free layout files hosted on Github.

Ildar Mulyukov, child of God

email: ildar.mulyukov@gmail.com GoogleTalk: ildar.mulyukov@gmail.com blog: http://johan-notes.blogspot.com/

[ligi]

@ildar the problem is not github - the problem are the ToS of the texture provider

[ligi]

Some initial experiments with the dark background - this will be a bit more work than I thought

[JohnPablok]

Wow! Looks great to me! By the way, if you want to make the images darker/lighter o tweak the color a bit just tell me and I'll do it.

[ligi]

thanks, but if you say it looks good I would leave it this way. Was a bit afraid that the contrast black text on dark bg is too little - thought I have to go white. Also I am not sure about the blue turn indicator - is really popping on the dark bg

[JohnPablok]

The blue turn indicator could be made Red in dark mode but only if it isn't a hassle to code, it doesn't look bad. I think the contrast with the background is good but I might edit the image a bit tomorrow, a bit less reddish and a bit lighter.

[JohnPablok]

In case you want it here's the background just a bit lighter and a bit less red.

[ligi]

So this is getting further - might use white font after-all - gives more consistency in night mode

[ligi]

Version 2.3.2 ( now in beta ) has initial day/night-mode support - feedback welcome

[JohnPablok]

Yay! Looks awesome in the pics, although for some reason it is crashing in both my Moto G and my galaxy note 10.1 tablet when selecting the Night option in the settings. Auto mode seems to work, but it's daytime here so I can't see the visual change.

[ligi]

Thanks - the minify process seems to have removed the resource for night - I will search for a way to protect it and file aug in the android bugtracker

[ligi]

I uploaded 2.3.3 to beta - should work now

[JohnPablok]

Looks great! Although I have to agree on what you said previously. The board lines are a bit difficult to discern, but mainly because they are only 1 pixel thick. Maybe the updated image could work (it is a bit lighter)

[ligi]

Using this image for night in 2.3.4

[ligi]

btw as I have someone with gfx skills here - it would be super awesome to get replacements for these 2 images which I amateurish clicked together with gimp. But they are for a lot of people the first and maybe only contact to gobandroid as these are the play feature graphics:

[JohnPablok]

I actually like those images! But I'll see if I can come up with something better :smiley: